8000 Fix: more forgiving drawer regexps by progfolio · Pull Request #15 · alphapapa/org-make-toc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: more forgiving drawer regexps #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix: more forgiving drawer regexps #15

wants to merge 2 commits into from

Conversation

progfolio
Copy link
Contributor

Abstract regexp for beginning of :CONTENTS: drawers into a variable.
Allow whitespace before :CONTENTS: and :END: drawer markers.

Ran into the "No TOC node found" user-error despite having a :CONTENTS: drawer.
This pull relaxes the regexps for drawer delimiters to allow for space between bol and the delimiter.
More closely matches org-clock-drawer-end-re.

Thanks again for the package!

@progfolio
Fix: more forgiving drawer regexps
2b30752 
Abstract regexp for beginning of :CONTENTS: drawers into a variable.
Allow whitespace before :CONTENTS: and :END: drawer markers.
@progfolio progfolio mentioned this pull request Nov 26, 2020
Closed
@alphapapa
Copy link
Owner

Thanks. We could use a defconst for the regexp, since it isn't intended to be changed.

@alphapapa alphapapa self-assigned this Nov 26, 2020
@alphapapa alphapapa added the bug label Nov 26, 2020
@progfolio
Copy link
Contributor Author

Good catch. Taken care of.

@progfolio
Copy link
Contributor Author

Tidying up things on my end. Closing this issue, but feel free to use the patch if you like.

@progfolio progfolio closed this Sep 24, 2022
@alphapapa
Copy link
Owner

@progfolio Please don't close PRs that haven't been handled yet.

@alphapapa alphapapa reopened this Sep 25, 2022
@progfolio
Copy link
Contributor Author

Please don't close PRs that haven't been handled yet.

Noted. I don't use the package any more, so the patch is offered "as is".
I've unsubscribed from notifications for this pull so that you can keep it open.

@alphapapa
Copy link
Owner

Thanks.

@mpereira
Copy link

@alphapapa is this good to merge? I bumped into this error yesterday.

@alphapapa alphapapa closed this in 7710579 Sep 4, 2023
@alphapapa
Copy link
Owner

@progfolio Thanks for fixing this and for your patience.

@mpereira Thanks for the reminder and your patience.

@mpereira
Copy link
mpereira commented Sep 4, 2023

@alphapapa thank you for the time you put into your many packages and for sharing them with us 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alphapapa alphapapa

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@progfolio @alphapapa @mpereira
0