Changed locking strategy #37
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Lloyd <mlloyd@pivotal.io>
8000
Signed-off-by: Mike Lloyd <kevin.michael.lloyd@gmail.com>
janisz
approved these changes
Apr 15, 2017
|
Tests hangs on Travis. Any idea why? |
|
No, it was hanging on my computer too. I didn't make any changes to the
tests, just the locking statements. Might be a deadlock, I can look into
it.
On Fri, Apr 14, 2017 at 10:55 PM janisz ***@***.***> wrote:
Tests hangs on Travis. Any idea why?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#37 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHMEsRD7xsl07IqeKnCYo28KuquMrcksks5rwFvQgaJpZM4M-MRu>
.
--
Thanks!
Mike Lloyd
USMC
808-633-8998
|
|
In get method not all paths unlock mutex. Can you refactor code to have only one return statement followed by unlock? This will make it easier to see the flow, lock at the beginning and unlock just after return. |
janisz
requested changes
Apr 15, 2017
| @@ -82,6 +81,7 @@ func (c *BigCache) Get(key string) ([]byte, error) { | |||
| if c.config.Verbose { | |||
| log.Printf("Collision detected. Both %q and %q have the same hash %x", key, entryKey, hashedKey) | |||
| } | |||
| shard.lock.RUnlock() | |||
There was a problem hiding this comment.
Not all returns are followed by unlock.
Signed-off-by: Mike Lloyd <kevin.michael.lloyd@gmail.com>
wendigo
approved these changes
Apr 18, 2017
|
@janisz we've been talking about it a couple of weeks ago :) |
|
@mxplusb Thanks! |
|
Awesome, glad to help! |
Closed
flisky
pushed a commit
to flisky/bigcache
that referenced
this pull request
May 7, 2020
There is a known issue in Go with deferred operations being much slower than explicit operations, both directly and indirectly impacting locking. Generally, on OS X and Windows, the change gives between 10-15% performance gain. Relates: golang/go#14939
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a known issue in Go with deferred operations being much slower than explicit operations, both directly and indirectly impacting locking.
Here are the performance comparisons (from benchstat) over 1000 iterations:
I did this over 1000 iterations because benchmarking nanosecond operations is hard to get consistent, so that gives a good view of the larger performance gain.
Generally, on OS X and Windows, the change gives between 10-15% performance gain.
Signed-off-by: Mike Lloyd mlloyd@pivotal.io