Update matching version #71

peterdesmet · 2024-01-22T13:49:59Z

@stijnvanhoey I think there were two issues with the previous regex.

The current version is more flexible. I did drop the matching for tags that do not start with v

stijnvanhoey

Afaik, github actions does not support fully regex, but provides some wildcards one can use, like * for any character, see also https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#patterns-to-match-branches-and-tags

peterdesmet · 2024-01-22T14:12:53Z

In that case 'v[0-9]*', '[0-9]*' rather than 'v[0-9]*', '[0-9]+.[0-9]+*' should be enough?

stijnvanhoey · 2024-01-22T14:16:27Z

In that case 'v[0-9]*', '[0-9]*' rather than 'v[0-9]*', '[0-9]+.[0-9]+*' should be enough?

Indeed. Or even only keep the ``'v[0-9]*'` if that is how you define versions

Update release.yml

6287426

peterdesmet requested a review from stijnvanhoey January 22, 2024 13:50

stijnvanhoey requested changes Jan 22, 2024

View reviewed changes

Update release.yml

03d9ba4

peterdesmet merged commit 811e76f into main Jan 22, 2024

peterdesmet deleted the version-tag branch January 22, 2024 14:43

Provide feedback