Feature fileselection #867
Conversation
When clicking on Drop Images Files / Folders (or the icon above) the user has now the option to do a multiselection of files to be added for reconstruction.
|
Thank you for the contribution. (I attached a screenshot for other users to illustrate your commits) I noted one thing that is not directly related to your commit: When using the new HDRI pipeline there is no SfM node, so "Augment Reconstruction" is without use. Maybe we could disable the Augment Reconstruction drop field/File Menu as long as there is no SfM node in the node graph to improve usability. @fabiencastan what do you think? |
You missed to highlight the extra menu separator ;)
When I start the application I get a full Photogrammetry pipeline. The augment menu entry is explicitly disabled, it is not common to hide menu entries in applications. What I did find out is that the augment droparea is enabled when there is a single image (images > 0), while it should actually be at least two (images >= 2). |
Yes, the black lines on dark grey background are hard to see
No, not hide, disable when using File->New pipeline->HDRI or when no SfM node is being used in the graph
Yes, that could be fixed, too. |
I see what you mean now, but it should also disable the drop area :-) Maybe open a new ticket? This sounds like a "good first issue" as well. |
|
I have added this to the Good-first-contributions list for now. |
|
@natowi it was easier than expected. What do you think about it? :-) |
|
@skinkie It works :-) |
|
About file types: I noted, that adding folders via the add images menu is not possible. |
|
I took the image fileformat list from the Python code. https://github.com/alicevision/meshroom/blob/develop/meshroom/multiview.py#L9 I have tried MP4 before, but it does not yet work. And you would be surprised that adding folders via dragging only works if the folder actually contains images, it does not work recursive. In addition QML does not allow both a multiple file selection and a folder selection. https://doc.qt.io/qt-5/qml-qtquick-dialogs-filedialog.html#selectFolder-prop |
When you drag and drop a mp4 file in Meshroom a new "KeyframeSelection" node is being created.
I see... |
|
What if we create a new menu "Assets" with:
Surely I want this to work recursively as well. But I think a good UI design should be made. |
I agree. Maybe we can take a look on how this is solved in other applications. But now it is enough for today I think :) |
|
I believe this feature was already added in this commit on #808 (Though I don't think it allows for augmentation currently) |
Would have been nice if that commit or pull request actually marked the issues. |
|
@ChemicalXandco thank you for the hint, I did not see this, too. How about this menu structure? Import Files (or Import...) Augment Reconstruction (could directly open the add images window as long as adding folders for augmentation is not supported) |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
https://github.com/alicevision/meshroom/wiki/Good-first-contributions point that Add file picker to add images would be a good start for development. This would Fix #461 and Fix #825
Features list
Implementation remarks
I would like to put down in this pull request has been my first contribution, and first QML work, which I found challenging. The first commit updates the Python interface, which splits the drag and drop slot to a drag and drop, and a more generic list of URLs.
The second commit adds the ability to be able to click on both the icon as the drop label. I choose this approach to prevent issues when clicking on any image later, this allowing the most obvious place a user would be able to click first. I added the new signal in because the different object type QObject vs QList. I used FileDialog from QtQuick.Dialogs to allow a multifile selection. I wonder if the other Platform.FileDialog's should be updated in the future.
The third commit adds two menu entries, in order to add images dragless. As programmer I would have liked to reuse the same FileDialog, I don't know if this would be an anti-pattern in QML. I found it very hard to just reuse the FileDialog from one of the files. I would love to hear if it this is possible at all.