Adapt to the spring cloud 2020.1 #1978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use spring.cloud.version instead of the version number of each component
|
what's happening? It's been ten days, nothing happened. |
HaojunRen
reviewed
Mar 17, 2021
| @@ -131,7 +131,7 @@ public void start() { | |||
| } | |||
| } | |||
| catch (MQClientException e) { | |||
| logger.error("fetch publish message queues fail", e); | |||
| logger.error(e, "fetch publish message queues fail"); | |||
There was a problem hiding this comment.
What is the reason for this refactory of exeception logic?
There was a problem hiding this comment.
In the 2020 version, Spring uses LogAccessor instead of commons.logging
HaojunRen
reviewed
Mar 17, 2021
| @@ -59,7 +59,7 @@ public static ConsulAutoRegistration registration( | |||
| service.setAddress(sidecarProperties.getIp()); | |||
| } | |||
| service.setName(normalizeForDns(appName)); | |||
| service.setTags(createTags(properties)); | |||
| service.setTags(properties.getTags()); | |||
There was a problem hiding this comment.
In Spring Cloud 2020, Consul tags and metadata logic has been changed, please pay attension
HaojunRen
reviewed
Mar 17, 2021
| * 由于初始化顺序发生变更，这里为了避免循环依赖，只能通过 BeanDefinition 的方式获得 FeignClientFactoryBean | ||
| * 需要重点review | ||
| */ | ||
| // FeignClientFactoryBean feignClientFactoryBean = (FeignClientFactoryBean) Builder.this.applicationContext |
There was a problem hiding this comment.
Change to Chinese comments
There was a problem hiding this comment.
Sorry, my mistake, it has been changed to English
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to the spring cloud 2020.1