8000 [ISSUE #3907] when publishConfig, if type is absent, set default value 'text' by horizonzy · Pull Request #3915 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
< 8000 div itemscope itemtype="http://schema.org/SoftwareSourceCode" class="">

[ISSUE #3907] when publishConfig, if type is absent, set default value 'text' #3915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2020
Merged

[ISSUE #3907] when publishConfig, if type is absent, set default value 'text' #3915

merged 2 commits into from
Nov 9, 2020

Conversation

horizonzy
Copy link
Collaborator

What is the purpose of the change

fix-#3907

@KomachiSion
Copy link
Collaborator

I think it can't fix the issue, it will cause the type be replaces with text.

@horizonzy
Copy link
Collaborator Author

I think it can't fix the issue, it will cause the type be replaces with text.

It just replaced when type not setted. when type not setted, we set default value as 'text' or throw exception?

@KomachiSion
Copy link
Collaborator

I think the solution should be to modifying config-client, get the type by dataId suffix, if not suffix or unsupported suffix, use text as default.

@KomachiSion KomachiSion mentioned this pull request Nov 4, 2020
Closed
5 tasks
@horizonzy
1.add publishConfig api(add param type)
af4b048 
2.check type is valid in nacos server
@horizonzy
Copy link
Collaborator Author

@KomachiSion @chuntaojun
#2662 is no response, use this pr to fix it.

@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Nov 9, 2020
@KomachiSion KomachiSion added this to the 1.4.1 milestone Nov 9, 2020
@KomachiSion KomachiSion merged commit 39a2f20 into alibaba:develop Nov 9, 2020
@KomachiSion KomachiSion linked an issue Nov 9, 2020 that may be closed by this pull request
调用 publishConfig 会覆盖数据库 type 字段 #3907
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

Assignees
No one assigned
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

调用 publishConfig 会覆盖数据库 type 字段
2 participants
@horizonzy @KomachiSion
0