8000 [ISSUE #13297] Add build-helper-maven-plugin to support IDEA auto-recognize generated sources by zhilu-tang · Pull Request #13298 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ISSUE #13297] Add build-helper-maven-plugin to support IDEA auto-recognize generated sources #13298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

[ISSUE #13297] Add build-helper-maven-plugin to support IDEA auto-recognize generated sources #13298

merged 1 commit into from
Apr 28, 2025

Conversation

zhilu-tang
Copy link
Contributor

What is the purpose of the change

Add build-helper-maven-plugin in root pom.xml to help IDEA automatically recognize generated source files under target/generated-sources directory, avoiding red squiggles in IDEA after source code import.

Brief changelog

  • Add build-helper-maven-plugin configuration in root pom.xml to add generated sources directory

Verifying this change

  1. Import project into IDEA
  2. Verify that generated source files under target/generated-sources are properly recognized by IDEA
  3. Verify no red squiggles appear for the generated source files

This change:

  • is backwards-compatible
  • is covered by tests
  • affects documentation or requires documentation changes
  • breaks KV-storage compatibility
  • breaks HTTP API compatibility
  • breaks CLI compatibility
  • breaks Metrics compatibility

@zhilu-tang
[ISSUE alibaba#13297] Add build-helper-maven-plugin to support IDEA a…
76d5264 
…uto-recognize generated sources

## What is the purpose of the change
Add build-helper-maven-plugin in root pom.xml to help IDEA automatically recognize generated source files under target/generated-sources directory, avoiding red squiggles in IDEA after source code import.

## Brief changelog
- Add build-helper-maven-plugin configuration in root pom.xml to add generated sources directory

## Verifying this change
1. Import project into IDEA
2. Verify that generated source files under target/generated-sources are properly recognized by IDEA
3. Verify no red squiggles appear for the generated source files

This change:
- [ ] is backwards-compatible
- [x] is covered by tests
- [ ] affects documentation or requires documentation changes
- [ ] breaks KV-storage compatibility
- [ ] breaks HTTP API compatibility
- [ ] breaks CLI compatibility
- [ ] breaks Metrics compatibility
@github-actions GitHub Actions
Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io

感谢您提交的PR。 🙏
请再次查看您的PR内容，确认是否包含任何使用方式/API/配置参数的变更，如：新增API、新增配置参数、修改默认配置等操作。
如果是，请确保在提交之前，在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档（markdown格式）。

@CLAassistant
Copy link
CLAassistant commented Apr 23, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.20%. Comparing base (bb7e34e) to head (76d5264).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #13298      +/-   ##
=============================================
- Coverage      72.28%   72.20%   -0.08%     
+ Complexity     10063    10052      -11     
=============================================
  Files           1313     1313              
  Lines          42277    42277              
  Branches        4444     4444              
=============================================
- Hits           30560    30527      -33     
- Misses          9601     9623      +22     
- Partials        2116     2127      +11

see 35 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb7e34e...76d5264. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wuyfee
Copy link
wuyfee commented Apr 25, 2025

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
❌ - e2e-go-test (standalone & cluster): failure
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@KomachiSion KomachiSion merged commit 44164f7 into alibaba:develop Apr 28, 2025
8 checks passed
@KomachiSion KomachiSion linked an issue Apr 28, 2025 that may be closed by this pull request
make generated source code IDEA friendly #13297
Closed
@KomachiSion KomachiSion added this to the 2.5.2 milestone Apr 28, 2025
@KomachiSion KomachiSion mentioned this pull request Apr 29, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.

make generated source code IDEA friendly
5 participants
@zhilu-tang @CLAassistant @codecov-commenter @wuyfee @KomachiSion
0