8000 [noissue] bin/startup.sh, refactoring, extract variable by yjqg6666 · Pull Request #13263 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[noissue] bin/startup.sh, refactoring, extract variable #13263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in 8000 to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 21, 2025
Merged

[noissue] bin/startup.sh, refactoring, extract variable #13263

merged 3 commits into from
Apr 21, 2025

Conversation

yjqg6666
Copy link
Contributor
@yjqg6666 yjqg6666 commented Apr 17, 2025 •
edited
Loading

What is the purpose of the change

refactoring startup script

Brief changelog

  1. use a variable to store the log file path, instead of hard-coded multiple times.
  2. the log file contains stdout & stderr, startup.log file is preferred. start.out may mean output only.
  3. the echo command is not needed to run in background. And also no need to redirect stderr to stdout.
  4. variable/string concatenation style. pure variable in quotes, no curly braces needed, as "$var" . String and variable in quotes, braces needed, as "some string ${var}continue".

@yjqg6666 yjqg6666 changed the title bin/startup.sh, refactoring, extract variable [noissue] bin/startup.sh, refactoring, extract variable Apr 17, 2025
@codecov-commenter
Copy link
codecov-commenter commented Apr 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.28%. Comparing base (6daea18) to head (dba5e54).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #13263   +/-   ##
==========================================
  Coverage      72.27%   72.28%           
- Complexity     10064    10065    +1     
==========================================
  Files           1313     1313           
  Lines          42275    42275           
  Branches        4443     4443           
==========================================
+ Hits           30556    30558    +2     
+ Misses          9606     9605    -1     
+ Partials        2113     2112    -1

see 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6daea18...dba5e54. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yjqg6666
startup.sh, redirecting stderr to stdout is unnecessary.
9abb0ee 
Simply put string to file, the error is relating to writing.
If this failed, the stderr can also not be saved.
@wuyfee
Copy link
wuyfee commented Apr 17, 2025

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
❌ - e2e-go-test (standalone & cluster): failure
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@wuyfee
Copy link
wuyfee commented Apr 17, 2025

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
❌ - e2e-go-test (standalone & cluster): failure
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@wuyfee
Copy link
wuyfee commented Apr 17, 2025

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
❌ - e2e-go-test (standalone & cluster): failure
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@KomachiSion KomachiSion merged commit 6975a9b into alibaba:develop Apr 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yjqg6666 @codecov-commenter @wuyfee @KomachiSion
0