[ISSUE#7519] Optimize configuration history deletion logic #7531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realJackSun
previously approved these changes
Jan 5, 2022
|
@TsingLiang @shiyiyue1102 |
|
@li-xiao-shuang How do you see this? |
| try { | ||
| TimeUnit.SECONDS.sleep(1); | ||
| } catch (InterruptedException e) { | ||
| LogUtil.FATAL_LOG.error("[db-error] " + e, e); |
There was a problem hiding this comment.
这里的日志可以在明确一下 此处应该不是db 的error
config/src/main/java/com/alibaba/nacos/config/server/service/dump/DumpService.java
Show resolved
Hide resolved
| @@ -631,11 +632,20 @@ public boolean batchRemoveAggr(final String dataId, final String group, final St | |||
| @Override | |||
| public void removeConfigHistory(final Timestamp startTime, final int limitSize) { | |||
| String sql = "DELETE FROM his_config_info WHERE gmt_modified < ? LIMIT ?"; | |||
| PaginationHelper<ConfigInfo> helper = createPaginationHelper(); | |||
| ExternalStoragePaginationHelperImpl<Object> paginationHelper = (ExternalStoragePaginationHelperImpl<Object>) createPaginationHelper(); | |||
There was a problem hiding this comment.
ExternalStoragePaginationHelperImpl 是不是可以替换为 ExternalStoragePaginationHelperImpl< ConfigInfo > ？
|
|
li-xiao-shuang
approved these changes
Jan 7, 2022
look good |
realJackSun
approved these changes
Jan 14, 2022
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
for #7519
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.