#720 Memory leak in PushService #749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkorange
reviewed
Feb 15, 2019
| @@ -540,6 +541,7 @@ public void refresh() { | |||
| Loggers.PUSH.error("[NACOS-PUSH] failed to push data: {} to client: {}, error: {}", | |||
| ackEntry.data, ackEntry.origin.getAddress().getHostAddress(), e); | |||
| ackMap.remove(ackEntry.key); | |||
| udpSendTimeMap.remove(ackEntry.key); | |||
There was a problem hiding this comment.
The Java doc says that there is no guarantee that the exception will be thrown if the remote port is unreachable. So the remove key action here may not be executed.
There was a problem hiding this comment.
yes, when remote port is unreachable ,544 line remove operate will not execute。
but it will retry until max retry times, at last, 519 line remove operate will execute.
so it is no problem。
There was a problem hiding this comment.
Great, you are right. Please point your target branch to alibaba:develop next time.
KiteSoar
pushed a commit
to KiteSoar/nacos
that referenced
this pull request
Mar 1, 2025
Co-authored-by: heimanba <371510756@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix Memory leak