8000 [ISSUE #696] Nacos-server starts fail in windows by jifengnan · Pull Request #740 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ISSUE #696] Nacos-server starts fail in windows #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2019
Merged

[ISSUE #696] Nacos-server starts fail in windows #740

merged 2 commits into from
Feb 28, 2019

Conversation

jifengnan
Copy link
Contributor
@jifengnan jifengnan commented Feb 1, 2019 •
edited
Loading

Fixes #696.

Brief changelog

  • Added double quotation marks to avoid the issue caused by the folder names containing spaces.

  • Removed the last 5 chars(which means \bin) to get the base DIR, instead of the for loop.

Verifying this change

Tested and passed on both windows 7 and 10.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@jifengnan
Merge pull request #3 from alibaba/develop
fadea95 
Merge the newest code
@jifengnan
Fix the issue which the server started failed if folder names contain…
e40d899 
… spaces.

Tested and passed on both windows 7 and 10.
@CLAassistant
Copy link
CLAassistant commented Feb 1, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jifengnan jifengnan changed the title [ISSUE #696] Nacos-server startup fail is windows [ISSUE #696] Nacos-server starts fail in windows Feb 16, 2019
@xuechaos xuechaos merged commit 9636e81 into alibaba:develop Feb 28, 2019
@nacos-bot nacos-bot mentioned this pull request Mar 1, 2019
Closed
KiteSoar pushed a commit to KiteSoar/nacos that referenced this pull request Mar 1, 2025
@KomachiSion
Translate sidebar. (alibaba#740)
6797f75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jifengnan @CLAassistant @xuechaos
0