8000 Fix CMDB JVM option error by nkorange · Pull Request #647 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix CMDB JVM option error #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2019
Merged

Fix CMDB JVM option error #647

merged 2 commits into from
Jan 18, 2019

Conversation

nkorange
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fix CMDB JVM option error

Brief changelog

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@nkorange nkorange requested a review from xuechaos January 18, 2019 03:01
@nkorange nkorange merged commit 780bd18 into develop Jan 18, 2019
@nacos-bot nacos-bot mentioned this pull request Jan 18, 2019
Closed
KiteSoar pushed a commit to KiteSoar/nacos that referenced this pull request Mar 1, 2025
@Tinie13
feat:视频组件优化 (alibaba#647)
3b39b3b 
* fixed:readme优化

* feat:新增中文版README

* fixed:readme optimize

* fixed:add Project Structure

* fixed:Optimization of directory structure

* fixed:微服务全景图弹框位置优化

* fixed:暂不展示全景图

* fixed:全景图优化

* feat:视频组件优化

* feat:新增视频组件

* feat:提取常量

* feat:暂停除当前选中之外的所有视频

* feat：首页新增视频组件
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuechaos xuechaos Awaiting requested review from xuechaos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nkorange
0