8000 [ISSUE-#5182] Remove ConfigController#removeRequestContext method. by Maijh97 · Pull Request #5201 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ISSUE-#5182] Remove ConfigController#removeRequestContext method. #5201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2021
Merged

[ISSUE-#5182] Remove ConfigController#removeRequestContext method. #5201

merged 3 commits into from
Mar 26, 2021

Conversation

Maijh97
Copy link
Collaborator
@Maijh97 Maijh97 commented Mar 26, 2021

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix: #5182

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Maijh97 added 2 commits March 26, 2021 12:58
@Maijh97
fix alibaba#5182, After some discussion, 2.0 adopted a long connectio…
d762914 
…n approach and decided to remove RemoveRequest Context
@Maijh97
fix alibaba#5182, After some discussion, 2.0 adopted a long connectio…
6b7ea77 
…n approach and decided to remove RemoveRequest Context
@Maijh97 Maijh97 requested a review from shiyiyue1102 March 26, 2021 05:06
@Maijh97 Maijh97 added area/Config kind/bug Category issues or prs related to bug. labels Mar 26, 2021
@Maijh97 Maijh97 added this to the 2.0.1 milestone Mar 26, 2021
@Maijh97 Maijh97 merged commit 9cdfd95 into alibaba:feature_support_grpc_core Mar 26, 2021
@Maijh97 Maijh97 linked an issue Mar 26, 2021 that may be closed by this pull request
throw NoSuchFieldException in ConfigController when service connect to nacos #5182
Closed
@Maijh97 Maijh97 mentioned this pull request Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiyiyue1102 shiyiyue1102 shiyiyue1102 approved these changes

56A8
Assignees
No one assigned
Labels
area/Config kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.

throw NoSuchFieldException in ConfigController when service connect to nacos
2 participants
@Maijh97 @shiyiyue1102
0