8000 Revert "[ISSUE #3102] Create utils class to nacos-common" by KomachiSion · Pull Request #4191 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "[ISSUE #3102] Create utils class to nacos-common" #4191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2020
Merged

Revert "[ISSUE #3102] Create utils class to nacos-common" #4191

merged 1 commit into from
Nov 10, 2020

Conversation

KomachiSion
Copy link
Collaborator

Reverts #4165

The reason is that the client,api and common module has remove the lang/lang3 denpendency. The added codes and method is for nacos-server modules.

And we think nacos-server can depend lang3 to reduce copy codes.

@KomachiSion KomachiSion added this to the 1.4.1 milestone Nov 10, 2020
@KeRan213539 KeRan213539 merged commit 8950304 into develop Nov 10, 2020
@KomachiSion KomachiSion deleted the revert-4165-develop-issue#3102 branch November 10, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeRan213539 KeRan213539 KeRan213539 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@KomachiSion @KeRan213539
0