8000 Improve test coverage for container package by alexei-led · Pull Request #268 · alexei-led/pumba · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve test coverage for container package #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 16, 2025
Merged

Improve test coverage for container package #268

merged 7 commits into from
Mar 16, 2025

Conversation

alexei-led
Copy link
Owner

Summary

  • Added test for waitForStop and StressContainer functionality
  • Fixed the timeout test in waitForStop to properly handle container states
  • Added test coverage for core container operations including restart, start/stop and remove
  • Increased test coverage for the container package from 48% to 49%

Test plan

  • All unit tests pass
  • Added tests for StressContainer and waitForStop functions
  • Added tests for other container interface methods to ensure proper coverage
  • Test that timeout handling is working correctly for long-running operations

This PR is part of a larger effort to provide a safety net of tests before refactoring the code to support multiple container runtimes.

@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 16, 2025 •
edited
Loading

Test Results

228 tests   221 ✅  0s ⏱️
  6 suites    7 💤
  1 files      0 ❌

Results for commit f44f766.

♻️ This comment has been updated with latest results.

@alexei-led alexei-led merged commit fa0c7c7 into master Mar 16, 2025
6 checks passed
@alexei-led alexei-led deleted the improve-test-coverage branch March 16, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexei-led
0