support specifying multiple target IP's #58
Conversation
b9cbf77 to
687daf9
Compare
|
did some testing, seems to work well for me. ready for review ! :) |
|
@Dieterbe CI build fails, but it's CI bug we are going to fix. Ignore it for now. I will review it manually. |
|
@Dieterbe there are some test that fails you can run tests with p.s.: can you, please also add a test for multiple IPs Thank you |
|
I will try to get to that soonish, but fyi I think i'll be quite busy with other stuff the next few days |
we now parse multiple ip's, comma separated. also: validate ip's early on. previously we would silently ignore ip parse errors
was introduced in 36d0ccd
687daf9 to
7f4ecd8
Compare
|
@alexei-led how does it look now? codefresh won't show me the build results unless I sign up, and signing up requires a whole bunch of permissions which i'm not willing to permit. |
|
@Dieterbe thank you for the contribution! |
we now parse multiple ip's, comma separated.
also: validate ip's early on. previously we would silently ignore ip
parse errors
fix #57
note: still need to test further, but this shows how i go about it.