8000 Update filebrowser to v2.32.0 by el · Pull Request #1858 · alexbelgium/hassio-addons · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update filebrowser to v2.32.0 #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update filebrowser to v2.32.0 #1858

wants to merge 6 commits into from

Conversation

el
Copy link
Contributor
@el el commented May 3, 2025 •
edited by coderabbitai bot
Loading

Tested locally:

SCR-20250503-szxh

Summary by CodeRabbit

  • New Features

    • Added an explicit ingress port (8071) for easier access to the Filebrowser addon.

  • Chores

    • Updated Filebrowser to version 2.32.0, including a new base image and versioning in documentation and configuration files.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 3, 2025 •
edited
Loading

Walkthrough

The changes update the Filebrowser addon to use version 2.32.0, including a new changelog entry, a switch to a new image repository and version in the build configuration, and an explicit ingress port mapping in the addon configuration. The internal service port is now bound to host port 8071, and the version number is updated accordingly. The update metadata was also refreshed to reflect the newer version and update date. No changes were made to code logic or exported entities.

Changes

File(s) Change Summary
filebrowser/CHANGELOG.md Added a new changelog entry for version 2.32.0 dated 03-04-2025 noting "Update to latest image."
filebrowser/build.json Updated base image references for all architectures to use filebrowser/filebrowser:v2.32.0 instead of previous image.
filebrowser/config.json Set explicit ingress port 8071, mapped internal port 8080 to host port 8071, incremented addon version.
filebrowser/updater.json Updated last_update to "31-01-2025" and upstream_version to "2.32.0" to reflect the new version.

Poem

🐇
A hop to version thirty-two,
With ports aligned and images new,
The changelog marks the latest feat,
Filebrowser’s update is now complete!
Onward we bound, with configs neat,
A rabbit’s work—swift and fleet!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac28ca7 and 8c0abd2.

📒 Files selected for processing (1)
  • filebrowser/updater.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • filebrowser/updater.json
⏰ Context from c 8000 hecks skipped due to timeout of 90000ms (1)
  • GitHub Check: Codacy Static Code Analysis

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 3, 2025
View reviewed changes
Copy link
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bcd9ad2 and ac28ca7.

📒 Files selected for processing (3)
  • filebrowser/CHANGELOG.md (1 hunks)
  • filebrowser/build.json (1 hunks)
  • filebrowser/config.json (3 hunks)
🧰 Additional context used
🪛 GitHub Actions: PR Check Build
filebrowser/CHANGELOG.md

[error] 1-1: No new entries in filebrowser CHANGELOG.md file!

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (4)
filebrowser/build.json (1)

3-5: Upgrade base image references.
The build_from entries now correctly point to filebrowser/filebrowser:v2.32.0 for all architectures. Verify that this repository and tag exist (per your local testing screenshot). Otherwise, this lgtm.

filebrowser/config.json (3)

84-84: Validate ingress_port usage.
You’ve added "ingress_port": 8071. Please confirm this key is supported by the Home Assistant addon schema and won’t conflict with ingress: true.

106-106: Map container port to host port.
The "8080/tcp": 8071 mapping aligns with your ingress port—but if you rely solely on ingress, this direct host mapping may be unnecessary. Ensure port 8071 isn’t already in use on the host.

131-131: Bump addon version.
Version updated to "2.32.0", matching build.json and your new changelog entry. Looks good.

filebrowser/CHANGELOG.md
Comment on lines +1 to +4
## 2.32.0 (03-04-2025)

- Update to latest image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Fix CHANGELOG entry format to satisfy CI.
The pipeline check reports no new entries detected. Ensure your new release header and bullet use the exact style the CI expects (e.g., a blank line after the header and * for list items). For example:

-## 2.32.0 (03-04-2025)
-
-- Update to latest image
+## 2.32.0 (03-04-2025)
+
+* Update to latest image
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## 2.32.0 (03-04-2025)
- Update to latest image
## 2.32.0 (03-04-2025)
* Update to latest image
🧰 Tools
🪛 GitHub Actions: PR Check Build

[error] 1-1: No new entries in filebrowser CHANGELOG.md file!

@alexbelgium
Copy link
Owner

Hi, have you tested file upload? This is the part failing thanks

@el
Copy link
Contributor Author
el commented May 4, 2025

Ahh, seems like you are right, the upload only works if you access it outside of ingress.

@alexbelgium
Copy link
Owner

We would need to find a way to disable TUS. I tried a bit but couldn't find how

@el
Copy link
Contributor Author
el commented May 4, 2025

I am hoping this will fix it:
home-assistant/core#144231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@el @alexbelgium
0