8000 Migrate last Pydantic V1 parsing methods by nesitor · Pull Request #781 · aleph-im/pyaleph · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Migrate last Pydantic V1 parsing methods #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Migrate last Pydantic V1 parsing methods #781

merged 1 commit into from
Apr 23, 2025

Conversation

nesitor
Copy link
Member
@nesitor nesitor commented Apr 23, 2025 •
edited
Loading

Fix: Migrate pending pydantic v1 deprecated parsing methods for the pydantic v2

Self proofreading checklist

  • Is my code clear enough and well documented
  • Are my files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • Database migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

Fix: Migrate pending pydantic v1 deprecated parsing methods for the pydantic v2

@nesitor nesitor requested review from amalcaraz and 1yam April 23, 2025 14:33
@nesitor nesitor self-assigned this Apr 23, 2025
amalcaraz
amalcaraz previously approved these changes Apr 23, 2025
View reviewed changes
Copy link
Collaborator
@amalcaraz amalcaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nesitor nesitor force-pushed the andres-fix-migrate_remaining_pydantic1_methods branch from 993eb1f to 90439ad Compare April 23, 2025 14:38
@nesitor nesitor requested a review from amalcaraz April 23, 2025 14:38
@nesitor nesitor merged commit 703fa45 into main Apr 23, 2025
5 of 7 checks passed
@nesitor nesitor deleted the andres-fix-migrate_remaining_pydantic1_methods branch April 23, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amalcaraz amalcaraz amalcaraz approved these changes

@1yam 1yam Awaiting requested review from 1yam

Assignees

@nesitor nesitor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nesitor @amalcaraz
0