8000 Fix: Redundant dependency in pyproject by hoh · Pull Request #207 · aleph-im/aleph-sdk-python · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Redundant dependency in pyproject #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Fix: Redundant dependency in pyproject #207

merged 1 commit into from
Mar 11, 2025

Conversation

hoh
Copy link
Member
@hoh hoh commented Mar 11, 2025

No description provided.

@hoh hoh requested a review from Psycojoker March 11, 2025 09:37
@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Mar 11, 2025
@github-actions GitHub Actions
Copy link

Summary:
The PR involves a significant change to the pyproject.toml file, which is a configuration file for Python projects. The removal of pynacl from the optional-dependencies.tezos section is likely to have a substantial impact on the project, as pynacl is a dependency for interacting with certain cryptographic functions, and its removal could affect the functionality of the project, especially in security-sensitive aspects.

Highlighting relevant parts of the diff:

-  "pynacl",
+  # Removed for security reasons, replaced by pytezos-crypto

Explanation:
The removal of pynacl from the optional-dependencies.tezos section is a significant change that could potentially introduce bugs or affect the project's security posture. The comment "Removed for security reasons, replaced by pytezos-crypto" suggests that there is a specific reason for this removal, but without more context, it is difficult to fully understand the implications of this change. Given the potential impact on cryptographic functionalities and security, this PR should be reviewed by experienced developers who have a deep understanding of the project's architecture and dependencies. Therefore, it is categorized as 'BLACK'.

@Psycojoker Psycojoker merged commit 0892735 into main Mar 11, 2025
23 checks passed
@Psycojoker Psycojoker deleted the hoh-cleanup-dependencies branch March 11, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Psycojoker Psycojoker Psycojoker approved these changes

Assignees
No one assigned
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoh @Psycojoker
0