8000 Fix wrong account config alert by nesitor · Pull Request #184 · aleph-im/aleph-sdk-python · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix wrong account config alert #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2024
Merged

Fix wrong account config alert #184

merged 1 commit into from
Nov 15, 2024

Conversation

nesitor
Copy link
Member
@nesitor nesitor commented Nov 6, 2024

Wrong account config alert where shown loading the default account:
wrong alert

This PR fixes that wrong warning message.

@nesitor nesitor requested a review from philogicae November 6, 2024 18:43
@nesitor nesitor self-assigned this Nov 6, 2024
@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Nov 6, 2024
@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 6, 2024

Summary:
The PR involves a significant change in the logic for loading accounts, particularly in how the chain and account type are determined. The new logic includes defaulting to a chain if no configuration is found and ensures consistency in the use of chain information across different parts of the code. This change could potentially affect the behavior of the application, especially if the chain information is crucial for operations.

Highlighting:

  • Changes in the logic for determining the chain and account type, including defaulting behavior.
  • Potential impact on the application's behavior if the chain information is used in critical operations.

This categorization is based on the potential for introducing bugs or requiring deep understanding of the project architecture, which aligns with the 'BLACK' complexity level.

philogicae
philogicae approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member
@philogicae philogicae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philogicae philogicae merged commit a1c7313 into main Nov 15, 2024
13 checks passed
@philogicae philogicae deleted the andres-fix-solve_account_config_warning branch December 19, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philogicae philogicae philogicae approved these changes

Assignees

@nesitor nesitor

Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nesitor @philogicae
0