Add command to create and start a confidential instance #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
Psycojoker
reviewed
Jul 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #235 +/- ##
==========================================
- Coverage 41.39% 39.53% -1.87%
==========================================
Files 18 18
Lines 1551 1667 +116
Branches 257 282 +25
==========================================
+ Hits 642 659 +17
- Misses 890 989 +99
Partials 19 19 ☔ View full report in Codecov by Sentry. |
Psycojoker
approved these changes
Jul 25, 2024
|
@olethanh you can squash & merge whenever you want for me |
if an user passed the --hypervisor option, the question was still asked
5153556 to
6c6980c
Compare
nesitor
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aleph instance createaleph instance confidential-init-sessioncommand to init the confidential sessions (get platform certificate, generate session certificate and upload them)aleph instance confidential-startcommand to fetch the measurement from the server and start the VM (get measurements from server, validate them again locally calculated one and send the secret to the server)I tested command separately against staging pyaleph and aleph-vm but the whole flow need to be thoroughly tested.