8000 Feature: account managment and sol by 1yam · Pull Request #281 · aleph-im/aleph-client · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature: account managment and sol #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 14, 2024
Merged

Feature: account managment and sol #281

merged 20 commits into from
Oct 14, 2024

Conversation

1yam
Copy link
Member
@1yam 1yam commented Sep 30, 2024 •
edited
Loading

This PR allow usage of multiple chain more easily on aleph-client

Related ClickUp, GitHub or Jira tickets : ALEPH-51

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Documentation

The documentation regarding the impacted features is available on:

Not done yet

The changes in the documentation are available here:

Not done yet

Changes

We now handle the new account handling (also added handler in the instance creations)

How to test

pip install git+https://github.com/aleph-im/aleph-sdk-python.git@1yam-solana-acount
aleph account create # add new account
aleph account list # list all linked account
aleph account config # add account only to the config.json
aleph account update # update specific account

Print screen / video

image
image
image

Notes

Most of the change is handle by the change in aleph-sdk-python, expect for payment handling so also need testing on aleph instance create

@1yam 1yam requested review from philogicae and nesitor September 30, 2024 13:45
@github-actions GitHub Actions
Copy link

Failed to retrieve llama text: POST 504:

504 Gateway Time-out


The server didn't respond in time.

Psycojoker
Psycojoker reviewed Oct 3, 2024
View reviewed changes
Psycojoker
Psycojoker reviewed Oct 3, 2024
View reviewed changes
@philogicae
Copy link
Member
philogicae commented Oct 7, 2024 •
edited
Loading

Updated commands

image

Helpers

image

@codecov Codecov
Copy link
codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 39.66667% with 181 lines in your changes missing coverage. Please review.

Project coverage is 39.82%. Comparing base (05cdfc6) to head (ce8f351).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/aleph_client/commands/instance/__init__.py 7.61% 96 Missing and 1 partial ⚠️
src/aleph_client/commands/account.py 55.33% 45 Missing and 22 partials ⚠️
src/aleph_client/commands/utils.py 21.42% 11 Missing ⚠️
src/aleph_client/commands/message.py 62.50% 3 Missing ⚠️
src/aleph_client/utils.py 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   38.87%   39.82%   +0.94%     
==========================================
  Files          18       18              
  Lines        1932     2117     +185     
  Branches      335      260      -75     
==========================================
+ Hits          751      843      +92     
- Misses       1141     1222      +81     
- Partials       40       52      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philogicae philogicae self-assigned this Oct 9, 2024
@philogicae philogicae removed their request for review October 9, 2024 14:47
@philogicae philogicae force-pushed the 1yam-account-managment-and-sol branch from b9c349c to c96fc18 Compare October 9, 2024 14:59
@nesitor nesitor requested a review from Psycojoker October 10, 2024 09:04
@philogicae philogicae force-pushed the 1yam-account-managment-and-sol branch 2 times, most recently from 0b30183 to 76a706c Compare October 11, 2024 02:14
@philogicae philogicae force-pushed the 1yam-account-managment-and-sol branch from 76a706c to a8b866f Compare October 11, 2024 02:24
nesitor
nesitor approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member
@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philogicae philogicae force-pushed the 1yam-account-managment-and-sol branch from 1a2e584 to 958c651 Compare October 11, 2024 17:46
@philogicae philogicae force-pushed the 1yam-account-managment-and-sol branch from 958c651 to 65686ec Compare October 11, 2024 17:49
@philogicae philogicae force-pushed the 1yam-account-managment-and-sol branch from 59ff93c to cd1816e Compare October 11, 2024 18:38
@nesitor nesitor merged commit b3d00dc into master Oct 14, 2024
18 checks passed
@philogicae philogicae deleted the 1yam-account-managment-and-sol branch October 16, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesitor nesitor nesitor approved these changes

@Psycojoker Psycojoker Awaiting requested review from Psycojoker

Assignees

@philogicae philogicae

@1yam 1yam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1yam @philogicae @Psycojoker @nesitor
0