8000 Dot in a string breaks the highlighting in Terraform · Issue #988 · alecthomas/chroma · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Dot in a string breaks the highlighting in Terraform #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
nikpivkin opened this issue Aug 5, 2024 · 0 comments · Fixed by #1068
Closed
1 task done

Dot in a string breaks the highlighting in Terraform #988

nikpivkin opened this issue Aug 5, 2024 · 0 comments · Fixed by #1068
Labels
bug

Comments

@nikpivkin
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Input:

resource "aws_s3_bucket" "this" {
  bucket = "my-tf-test-bucket"

  website {
    index_document = "index.html"
    error_document = "error.html"
  }
}

Output:
image

To Reproduce

Link to Playground
@nikpivkin nikpivkin added the bug label Aug 5, 2024
esacteksab added a commit to esacteksab/chroma that referenced this issue Mar 30, 2025
@esacteksab
fix: fixes alecthomas#988
aa4d46a
@esacteksab esacteksab mentioned this issue Mar 30, 2025
Merged
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Apr 4, 2025
Update module github.com/alecthomas/chroma/v2 to v2.16.0 (forgejo) (#…
a0df27c 
…7459)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/alecthomas/chroma/v2](https://github.com/alecthomas/chroma) | require | minor | `v2.15.0` -> `v2.16.0` |

---

### Release Notes

<details>
<summary>alecthomas/chroma (github.com/alecthomas/chroma/v2)</summary>

### [`v2.16.0`](https://github.com/alecthomas/chroma/releases/tag/v2.16.0)

[Compare Source](alecthomas/chroma@v2.15.0...v2.16.0)

#### Changelog

-   [`ad6f149`](alecthomas/chroma@ad6f149) chore: clean up Makefile
-   [`9909f65`](alecthomas/chroma@9909f65) fix: switch to jsdelivr as unpkg was throwing CORS errors
-   [`34bf362`](alecthomas/chroma@34bf362) chore(deps): update all non-major dependencies ([#&#8203;1066](alecthomas/chroma#1066))
-   [`88084b6`](alecthomas/chroma@88084b6) fix: Dot in a string breaks the highlighting in Terraform. Fixes [#&#8203;988](alecthomas/chroma#988) ([#&#8203;1065](alecthomas/chroma#1065))
-   [`62197e9`](alecthomas/chroma@62197e9) Add lexers.Aliases() method to display only lexers' aliases ([#&#8203;1057](alecthomas/chroma#1057))
-   [`7feb358`](alecthomas/chroma@7feb358) chore(deps): update dependency svu to v3 ([#&#8203;1053](alecthomas/chroma#1053))
-   [`30e0bc6`](alecthomas/chroma@30e0bc6) chore(deps): update all non-major dependencies ([#&#8203;1061](alecthomas/chroma#1061))
-   [`e0c7747`](alecthomas/chroma@e0c7747)  Fix IP address as name detection in nginx conf ([#&#8203;1060](alecthomas/chroma#1060))
-   [`0bf0e9f`](alecthomas/chroma@0bf0e9f) Add luau file extension and alias to lua lexer ([#&#8203;1056](alecthomas/chroma#1056))
-   [`0e0e282`](alecthomas/chroma@0e0e282) chore(deps): update all non-major dependencies ([#&#8203;1049](alecthomas/chroma#1049))
-   [`4b0882a`](alecthomas/chroma@4b0882a) add Janet lexer ([#&#8203;1045](alecthomas/chroma#1045))
-   [`81fecd5`](alecthomas/chroma@81fecd5) chore(deps): update all non-major dependencies ([#&#8203;1041](alecthomas/chroma#1041))
-   [`dc982d2`](alecthomas/chroma@dc982d2) Add Mojo lexer ([#&#8203;1044](alecthomas/chroma#1044))
-   [`79621af`](alecthomas/chroma@79621af) Fix solidity lexer's handling of inline assembly ([#&#8203;1040](alecthomas/chroma#1040))
-   [`9da461e`](alecthomas/chroma@9da461e) chore(deps): update module github.com/mattn/go-colorable to v0.1.14 ([#&#8203;1039](alecthomas/chroma#1039))
-   [`f0d460e`](alecthomas/chroma@f0d460e) Update Odin lexer for new build tag feature ([#&#8203;1038](alecthomas/chroma#1038))
-   [`0bd7c68`](alecthomas/chroma@0bd7c68) chore: bump go.mod to Go 1.22 + add Iterator.Stdlib()
-   [`d829579`](alecthomas/chroma@d829579) fix(ocaml): support multistring ([#&#8203;1035](alecthomas/chroma#1035))
-   [`e79c813`](alecthomas/chroma@e79c813) chore(deps): update all non-major dependencies ([#&#8203;1029](alecthomas/chroma#1029))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMjIuMSIsInVwZGF0ZWRJblZlciI6IjM5LjIyMi4xIiwidGFyZ2V0QnJhbmNoIjoiZm9yZ2VqbyIsImxhYmVscyI6WyJkZXBlbmRlbmN5LXVwZ3JhZGUiLCJ0ZXN0L25vdC1uZWVkZWQiXX0=-->

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7459
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
@esacteksab esacteksab mentioned this issue Apr 16, 2025
Merged
alecthomas pushed a commit that referenced this issue Apr 16, 2025
@esacteksab
fix: properly tokenizes default_tags attribute (#1068)
9077658 
In the current version `default_tags` was getting processed like

```json
{"type":"NameAttribute","value":"default"},
{"type":"Error","value":"_"},
{"type":"NameOther","value":"tags"}
```

but `default_tags` is a valid attribute or parameter here and doesn't
need parsed as such. This matches `default_tags` properly

Here is the before

![default_tags_2_16_capture](https://github.com/user-attachments/assets/fccf327a-82d5-4cc0-842e-acc2a605dce7)

And the after with this change

![fixed-default_tags-capture](https://github.com/user-attachments/assets/8c8f11cb-4e46-469e-bdce-6ddfc9a2d600)

Hopefully I did this correctly. I fixed #988 but it's been a minute.
Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: properly tokenizes default_tags attribute esacteksab/chroma
1 participant
@nikpivkin
0