8000 Escape character is now inserted for subsequent keypresses when the A… by TsarFox · Pull Request #1262 · alacritty/alacritty · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Escape character is now inserted for subsequent keypresses when the A… #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

TsarFox
Copy link
@TsarFox TsarFox commented Apr 23, 2018

…lt modifier is held down

I suppose this is more of a question on reasoning than a real request for my patch to be merged, is the behavior of enforcing self.ctx.received_count() to be zero typical? I noticed that using Emacs in alacritty felt a little bit off, since I tried to use M-< and M-> to navigate the buffer and it would only work for the first keystroke, with any subsequent keystrokes inserting '<' into the buffer. This is the only terminal emulator I've used that does this.

To reproduce this, I would suggest running cat and inserting key sequences while holding the alt key.

In URxvt:

$ cat
^[<^[>^[<^[>^[<^[>^[<^[>

In alacritty:

$ cat
^[<><><><>

@chrisduerr
Copy link
Member

How does this behave when keys are held down? Is this in line with other terminal emulators?

This check itself looks a bit interesting to me, maybe @jwilm knows why it was added at that point though.

@TsarFox
Copy link
Author
TsarFox commented Apr 23, 2018

The behavior for holding down a key is similar, only inserting the escape character once. URxvt and xterm insert the escape character every time when '<' or '>' are held down.

Although, while doing a little bit more experimentation I've found that this issue only applies to 'M-<' and 'M->'. I can hold Alt and insert nearly any other keystroke, including those where Shift is held down.

@jwilm
Copy link
Contributor
jwilm commented Apr 24, 2018

I have no idea why received_characters() == 0 was added. Git blame doesn't help either. 😞

I'll try removing it locally and see if I run into any problems.

@chrisduerr
Copy link
Member

@jwilm Have you found any issues with this?

@chrisduerr chrisduerr added this to the Version 0.2.6 milestone Jan 7, 2019
@chrisduerr
Copy link
Member

I think this has been resolved by a winit/glutin update. At least I can't reproduce it anymore. Sorry for keeping you waiting for so long, but seems like it worked out either way.

Please let me know if this issue still exists, then I'll re-open and test again.

@chrisduerr chrisduerr closed this Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants
0