Migrate to 2024 edition #8545
Open
Migrate to 2024 edition #8545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisduerr
commented
Apr 13, 2025
Comment on lines
+399
to
+403
| (KeyBinding, $key:literal, $location:expr) => {{ BindingKey::Keycode { key: Key::Character($key.into()), location: $location } }}; | ||
| (KeyBinding, $key:literal,) => {{ BindingKey::Keycode { key: Key::Character($key.into()), location: KeyLocation::Any } }}; | ||
| (KeyBinding, $key:ident, $location:expr) => {{ BindingKey::Keycode { key: Key::Named(NamedKey::$key), location: $location } }}; | ||
| (KeyBinding, $key:ident,) => {{ BindingKey::Keycode { key: Key::Named(NamedKey::$key), location: KeyLocation::Any } }}; | ||
| (MouseBinding, $base:ident::$button:ident,) => {{ $base::$button }}; |
There was a problem hiding this comment.
This is the only change I've noticed which was odd to me. I'm still looking into rustfmt and why it does this.
There was a problem hiding this comment.
There was a problem hiding this comment.
kchibisov
requested changes
Apr 13, 2025
ea91353 to
bdac750
Compare
kchibisov
reviewed
Apr 13, 2025
Good point, I would also like to at least get a reply about the two rustfmt issues I've opened to see where that is going in the future. Will keep it around for now, I'm in no hurry to merge this and I don't foresee any major conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's only been two months and distros are likely going to take a while to pick up Rust 1.85.0, but since there's no release around the corner anyway I thought I'd just see what needs changing for 2024 edition.