8000 Test compatible Ruby version and add Ruby versions to README and Github Action by BlazingRockStorm · Pull Request #9 · alchaplinsky/gen-ai · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test compatible Ruby version and add Ruby versions to README and Github Action #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 11, 2024
Merged

Test compatible Ruby version and add Ruby versions to README and Github Action #9

merged 4 commits into from
Oct 11, 2024

Conversation

BlazingRockStorm
Copy link
Contributor
@BlazingRockStorm BlazingRockStorm commented Oct 10, 2024 •
edited
Loading

My first contribute to the project, so to understand it, I first run tests and check the compatible Ruby version, then add the Compatibility part in README so that the user can setup the project to use the gem more easily.

@BlazingRockStorm
Copy link
Contributor Author

For the time being, Ruby version lower than 3.1 is not Compatitable
Screenshot 2024-10-10 at 16 08 51

@BlazingRockStorm BlazingRockStorm changed the title add Ruby version into Github Action Test compatible Ruby version and add Ruby versions to README and Github Actions Oct 10, 2024
@BlazingRockStorm BlazingRockStorm changed the title Test compatible Ruby version and add Ruby versions to README and Github Actions Test compatible Ruby version and add Ruby versions to README and Github Action Oct 10, 2024
@BlazingRockStorm BlazingRockStorm marked this pull request as ready for review October 10, 2024 07:25
@BlazingRockStorm
Copy link
Contributor Author

@alchaplinsky can you review the pull request for me?

alchaplinsky
alchaplinsky approved these changes Oct 11, 2024
View reviewed changes
Copy link
Owner
@alchaplinsky alchaplinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@alchaplinsky alchaplinsky merged commit a9e3290 into alchaplinsky:main Oct 11, 2024
4 checks passed
@BlazingRockStorm BlazingRockStorm deleted the add-ruby-version branch October 12, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alchaplinsky alchaplinsky alchaplinsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BlazingRockStorm @alchaplinsky
0