-
Notifications
You must be signed in to change notification settings - Fork 129
Minimum required set to get up and running on Heroku fails: Package is not installed: ext-mongo-1.6.12.0 #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Aah, nevermind, I now see mongo-php-adapter/composer.json Line 20 in 849de05
Does this part of the documentations still apply?
Deploying to Heroku
|
Just a quick word about the As for the error you are getting in that first example, I'll have to take a look at that. |
Thanks for the response. Well, turns out my CLI was at php {
"provide": {
"ext-mongo": "1.6.12"
},
"require": {
"alcaeus/mongo-php-adapter": "dev-master"
}
} But also without the |
The provide part is important when you add another package to the require. Go ahead and try adding the following packages to the
You'll find that you won't be able to install it with that |
Mm, ok, will experiment a bit, maybe heroku/heroku-buildpack-php#146 is not even an issue then... |
@alcaeus should the directive not be |
Summary is: root package needs to specify In an ideal world, |
Thanks for the detailed responses. The "ideal world" scenario sounds like a great place ;) Will run some additional tests to verify heroku/heroku-buildpack-php#146 is an issue or not.. |
So I had a conversation with @Seldaek yesterday and the tl;dr is that replace and provide should work pretty much the same way in this regard, and that both should be able to "override" PHP versions and extensions just like regular packages. |
That sounds good - the question is, should it be possible to define this override somewhere other than the root package? |
I believe the answer is yes. I have to create a few reproduce cases and then open a ticket showing which permutations work and which are broken. |
@dzuelke Thanks for all the effort you're putting into this - I'll update the documentation to use |
What about this combination: mongo-php-adapter says "replace" for |
If anything, this library would replace |
Well yes of course @jmikola. Typo. Fixed. |
Okay I can confirm that works, @alcaeus and @holtkamp (using the "composer-replace" branch since that still has it):
All is fine because If no dependency requires that package, then you need to do it in the
This appears to be the preferred approach according to composer/composer#2690, and it works under all circumstances - both with |
To use this package, either composer.json or any dependency needs to require "ext-mongo", see composer/composer#2690 and alcaeus#67 and heroku/heroku-buildpack-php#146
To use this package, either composer.json or any dependency needs to require "ext-mongo", see composer/composer#2690 and alcaeus#67 and heroku/heroku-buildpack-php#146
PR here: #70 |
PR has been merged. @holtkamp Can you close this issue if it's confirmed fixed with the latest |
mm, after removing my {
"require": {
"php": "^7.0",
"alcaeus/mongo-php-adapter": "dev-master",
"doctrine/mongodb": "dev-master"
}
} succeeds. However when pushing to Heroku, the buildpack still complains:
When doing the same attempt for the other described scenario, with a {
"require": {
"php": "^7.0",
"alcaeus/mongo-php-adapter": "dev-master",
"ext-mongo": "*"
}
} This results in:
So, I am not sure whether this issue can be closed just yet, did I test correctly? |
@holtkamp can you try |
Yes @holtkamp the change is not merged yet for the buildpack. Please test according to the instructions at heroku/heroku-buildpack-php#146 (comment) |
Mm, ok, sorry for my ignorance ;). In both cases this results in problems when on PHP 7.0.3 CLI:
And without
|
That's weird; if that happens on your box then it would have to happen on push to Heroku as well!? |
Closing this - the composer issue is being tracked in composer/composer#5030 while the actual install issue is tracked in #30. |
As Heroku is quite fast with adopting PHP 7, I am looking at using this.
After reading #58 and #30 I came up with a short test but even the most basic
composer.json
fails to install:Results in
Also changed
replace
withprovide
, but same result...Any idea where to look to at least get this installed?
The text was updated successfully, but these errors were encountered: