Feature/issues in apis table #2352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue column added in apiEndpoints table
Feature/issues in apis table
only show issue which are non-zero
old Issues text removed
Ark2307
reviewed
Apr 14, 2025
...oard/web/polaris_web/web/src/apps/dashboard/pages/observe/api_collections/ApiCollections.jsx
Show resolved
Hide resolved
Ark2307
reviewed
Apr 14, 2025
...hboard/web/polaris_web/web/src/apps/dashboard/pages/observe/api_collections/ApiEndpoints.jsx
Show resolved
Hide resolved
Ark2307
reviewed
Apr 14, 2025
| @@ -234,13 +241,15 @@ function ApiEndpoints(props) { | |||
| api.fetchApisFromStis(apiCollectionId), | |||
| api.fetchApiInfosForCollection(apiCollectionId), | |||
| api.fetchAPIsFromSourceCode(apiCollectionId), | |||
| api.loadSensitiveParameters(apiCollectionId) | |||
| api.loadSensitiveParameters(apiCollectionId), | |||
| issuesApi.fetchIssues(0,20000, [], [apiCollectionId], [], [], "severity", -1, 0, 0, true,[]) | |||
There was a problem hiding this comment.
- limit too high
- get only open issues
- add legit ts values {max 3-4 months data i guess
Ark2307
reviewed
Apr 14, 2025
|
|
||
| let data = {} | ||
| let allEndpoints = func.mergeApiInfoAndApiCollection(apiEndpointsInCollection, apiInfoListInCollection, collectionsMap) | ||
| let allEndpoints = func.mergeApiInfoAndApiCollection(apiEndpointsInCollection, apiInfoListInCollection, collectionsMap,apiInfoSeverityMap) |
There was a problem hiding this comment.
function called in 2 files, handle in both cases
There was a problem hiding this comment.
i think this line ...(apiInfoSeverityMap?.hasOwnProperty(key) ? { severityObj: apiInfoSeverityMap[key] } : {}) will handle it properly
Ark2307
reviewed
Apr 14, 2025
| if(!allIssues) return {} | ||
| let apiInfoSeverityMap = {} | ||
| allIssues.forEach(x => { | ||
| let key = x["id"]["apiInfoKey"]["apiCollectionId"] + "-" + x["id"]["apiInfoKey"]["url"] + "-" + x["id"]["apiInfoKey"]["method"] |
There was a problem hiding this comment.
use object.values.join("-") kind of thing
There was a problem hiding this comment.
in this the ordering wihich we get from apiInfo( apiCollectionId, method,url ) key is different so can't use object.values.join directly, or we need to change the key ordering in other places also ?
severity filter added , fetch only open issues and from last 90 days
|
Check out the changes done @Ark2307. If all seems good, let's proceed with merging it. 🫡 |
…ature/issues_in_apis_table
Feature/issues in apis table
|
have a look on new changes, @Ark2307 |
Ark2307
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.