8000 feat(html-content): innerHTML property by gilhanan · Pull Request #65 · akserg/ng2-toasty · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(html-content): innerHTML property #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2017
Merged

feat(html-content): innerHTML property #65

merged 1 commit into from
Feb 23, 2017

Conversation

gilhanan
Copy link
Contributor
@gilhanan gilhanan commented Feb 5, 2017 •
edited
Loading

Alternative for pull requests #63 and #64,
and admittedly this one is my favorite implementation.

  • What kind of change does this PR introduce?
    Close: Add 'html' content in title and messages #3

  • What is the current behavior? (You can also link to an open issue here)
    Not supporting 'html' content in toasts

  • What is the new behavior (if this is a feature change)?
    Supporting ability to projecting 'html' templates in toasts

  • Other information:
    Testings using this branch:
    ng2-webpack-demo/toasty-html-content

Using that code:

options = {
 title: 'HTML title: <span style="background-color: #1EAEDB; color: #E1CB00;">Toast It!</span>',
 msg: 'HTML message: <span style="background-color: #FF0039; color: #00E104;">Mmmm, tasties...</span>'
};

this.toastyService.default(toastOptions);

Gives the result:
toasty-html-content-demo

I would happy to review and discussing

@gilhanan gilhanan changed the title feat(html-content): innerHTML feat(html-content): innerHTML property Feb 5, 2017
@codedoge
Copy link

Nice, any chance to have this pulled in master?

@akserg akserg merged commit ee65355 into akserg:master Feb 23, 2017
@akserg
Copy link
Owner
akserg commented Feb 23, 2017

Hi Gil,

That solution much better than in pull requests #63 and #64.

Thank you for your valuable input.

This was referenced Feb 27, 2017
Closed
Closed
@gilhanan
Copy link
Contributor Author

@gilhanan gilhanan deleted the feat(html-content)-innerHTML branch February 27, 2017 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gilhanan @codedoge @akserg
0

@akserg thanks :)