Grafana auth_token MFA #225
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+27
to
+34
| def build(finch_process, %{host: host, auth_token: {m, f, a}}) do | ||
| %__MODULE__{ | ||
| finch_process: finch_process, | ||
| base_url: normalize_host(host), | ||
| authorization: "Bearer #{apply(m, f, a)}" | ||
| } | ||
| end | ||
|
|
There was a problem hiding this comment.
Why not accept a function too?
There was a problem hiding this comment.
My reason is that the mfa is coming in from a config file, and anonymous functions are a no-go there. Probably, an anonymous function could be accepted if passed in another way, but it was out of scope with what I was going for.
|
@akoutmos I don't think I'll be needing the functionality in this PR for now, so feel free to close it. (I did make a few documentation changes you might be interested in, though.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the grafana or metrics_server
auth_tokenconfigs to be MFAs. I need this for my company's infrastructure where Google IAP is in front of Grafana, and I need to fetch a token as needed with a 1 hour ttl.