8000 Boosting: Show when there is a problem retrieving a URL by akirk · Pull Request #464 · akirk/friends · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Boosting: Show when there is a problem retrieving a URL #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2025
Merged

Boosting: Show when there is a problem retrieving a URL #464

merged 1 commit into from
Feb 7, 2025

Conversation

akirk
Copy link
Owner
@akirk akirk commented Feb 7, 2025 •
edited
Loading

Fixes #460.

@akirk
Copy link
Owner Author
akirk commented Feb 7, 2025

Another try, @jeherve. Maybe there is an obscured error message for you?

@akirk akirk merged commit 58a6e52 into main Feb 7, 2025
27 checks passed
@akirk akirk deleted the fix-460-2 branch February 7, 2025 17:53
@jeherve
Copy link
Contributor
jeherve commented Feb 7, 2025

No error message I'm afraid. I do have a post ID, not a WP_Error, and that post ID matches a published friend_post_cache post.

@akirk
Copy link
Owner Author
akirk commented Feb 7, 2025

Ok thanks for checking that. So the URL is /friends/external/<postid> and it just doesn't display or the redirect is wrong?

@jeherve
Copy link
Contributor
jeherve commented Feb 7, 2025 •
edited
Loading

So the URL is /friends/external/ and it just doesn't display or the redirect is wrong?

I never get redirected to that URL when boosting from the Friends search field. But if I load it manually it displays the post correctly. And when I boost from that page, it works.

@akirk
Copy link
Owner Author
akirk commented Feb 7, 2025

By "load it manually" you mean entering the /friends/?boost=<url> in your URL bar?

For the redirect I just use wp_safe_redirect, not sure why it doesn't work for you.

@jeherve
Copy link
Contributor
jeherve commented Feb 12, 2025

By "load it manually" you mean entering the /friends/?boost=<url> in your URL bar?

Yes, exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boosting posts from folks I do not follow -> 404
2 participants
@akirk @jeherve
0