Use common bintray package #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
reviewed
Nov 10, 2016
| @@ -27,7 +27,8 @@ script: | |||
| deploy: | |||
| provider: script | |||
| script: | |||
| - sbt -J-XX:ReservedCodeCacheSize=128m +publish bintraySyncMavenCentral | |||
| # do the maven central sync only once, as all of the artifacts are under the same bintray package | |||
| - sbt -J-XX:ReservedCodeCacheSize=128m +publish amqp/bintraySyncMavenCentral | |||
There was a problem hiding this comment.
so this is only to publish amqp?
There was a problem hiding this comment.
All of the subprojects share the same bintray package. So calling this task on one subproject will sync all of the artifacts in the bintray package.
Calling the aggregate bintraySyncMavenCentral task (for all subprojects) results in:
[error] (cassandra/*:bintraySyncMavenCentral) failed to sync akka/alpakka@0.1-RC2 with maven central: {"status":"Sync Failed","messages":"[Failed to close repository: comlightbend-1028. Server response:\n <nexus-error>\n <errors>\n <error>\n <id>*<\u002fid>\n <msg>Unhandled: Staging repository is already transitioning: comlightbend-1028<\u002fmsg>\n <\u002ferror>\n <\u002ferrors>\n<\u002fnexus-error>, Dropping existing partial staging repository.]"}
There was a problem hiding this comment.
just like it said in the comment, sorry I didn't read
There was a problem hiding this comment.
ah, reading comments is over rated ;-)
johanandren
approved these changes
Nov 10, 2016
patriknw
approved these changes
Nov 10, 2016
| @@ -27,7 +27,8 @@ script: | |||
| deploy: | |||
| provider: script | |||
| script: | |||
| - sbt -J-XX:ReservedCodeCacheSize=128m +publish bintraySyncMavenCentral | |||
| # do the maven central sync only once, as all of the artifacts are under the same bintray package | |||
| - sbt -J-XX:ReservedCodeCacheSize=128m +publish amqp/bintraySyncMavenCentral | |||
| @@ -27,7 +27,8 @@ script: | |||
| deploy: | |||
| provider: script | |||
| script: | |||
| - sbt -J-XX:ReservedCodeCacheSize=128m +publish bintraySyncMavenCentral | |||
| # do the maven central sync only once, as all of the artifacts are under the same bintray package | |||
| - sbt -J-XX:ReservedCodeCacheSize=128m +publish amqp/bintraySyncMavenCentral | |||
There was a problem hiding this comment.
ah, reading comments is over rated ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So all of the subprojects can be released at once, and new subprojects do not need maintenance when being released the first time (like requesting new bintray package to be included into JCenter).