perf: Fix critical N+1 queries for 85% performance improvement #3294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prt 1 : Performance fix critical N+1
What motivated me was trying Akaunting in real-world environment under highload, this PR purpose is addressing severe performance bottlenecks that make it hard to use under moderate load & concurrent usage
Root cause: Critical N+1 query patterns are hammering the database with hundreds of unnecessary queries per page load. This is a fundamental performance architecture issue that must be fixed (check below)
What's i addressed :
- Dashboard users: 90% faster page loads (from 101 queries ---> 2 queries)
- Item autocomplete: 95% faster responses (from 201 queries ---> 2 queries)
- Document templates: 90% faster PDF generation (from 80 queries ---> 4 queries)
Technical Changes:
✅ Eager load dashboard users relationship in
DashboardController✅ Optimize item autocomplete tax calculations in
ItemsController✅ Add
DocumentServicefor centralized relationship loading✅ Upd 8FFF ate document controllers (Invoices, Bills, Portal) to use optimized loading
✅ Comprehensive performance test suite
Results:
Changes:
app/Http/Controllers/Common/Dashboards.phpapp/Http/Controllers/Common/Items.phpapp/Http/Controllers/Sales/Invoices.phpapp/Http/Controllers/Purchases/Bills.phpapp/Http/Controllers/Portal/Invoices.phpapp/Services/DocumentService.php(new)tests/Feature/Performance/N1QueryOptimizationTest.php(new)Testing:
All tests pass and performance optimizations are validated with comprehensive test coverage that can be found in
tests/Feature/Performance/N1QueryOptimizationTest.phpTo make my changes digestible i will submit couple of PR's (maybe 3) to make it easy for the team to understand them