8000 Job Completion Notification by tooolbox · Pull Request #213 · ajvb/kala · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Job Completion Notification #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2020
Merged

Job Completion Notification #213

merged 2 commits into from
May 25, 2020

Conversation

tooolbox
Copy link
Collaborator
@tooolbox tooolbox commented May 23, 2020

Replaces #212

Fixes #205

I think there's something odd with the CircleCI settings, but I don't have access.

@tooolbox
Copy link
Collaborator Author

Fantastic...

@tooolbox
Copy link
Collaborator Author

@ajvb Hey man, it looks like the settings for CircleCI or GitHub workflows changed somehow because now there's this additional ci/circleci Expected — Waiting for status to be reported that I did not see in earlier PRs. For example, this one only has one check: #211

When I hit up Google, I see a lot of results recommending to "disable the check on the protected branch". Unfortunately I don't have access to the branch settings in this repo.

Could you assist? Thanks!

@tooolbox tooolbox merged commit 4641406 into ajvb:master May 25, 2020
@tooolbox
Copy link
Collaborator Author

@ajvb So I figured out how to manually mark checks as complete to get around this particular issue, but it would still be great to fix this for the future.

Unfortunately I think this is my fault; when I clicked through to CircleCI I think it asked me if I wanted to upgrade to "Pipelines" and I hit "yes". The resulting problem is covered in the CircleCI docs: https://circleci.com/docs/2.0/workflows-waiting-status/

Basically seems like they changed the name of the checks and now this project is looking for the wrong one. So an admin (yourself) has to go in and fix that.

No particular rush but it would be good to resolve at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job Completion Notification
1 participant
0