8000 Fix duration time to consider playback rate by vicente-higino · Pull Request #1845 · ajayyy/SponsorBlock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ SponsorBlock Public

Fix duration time to consider playback rate #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix duration time to consider playback rate #1845

wants to merge 2 commits into from

Conversation

vicente-higino
Copy link
  • I agree to license my contribution under LGPL-3.0 or my contribution is from another project with a license compatible with LGPL-3.0

To test this pull request, follow the instructions in the wiki.

The duration of the video with skips now uses the playback rate to adjust the time.

Ex: 0:13 / 10:50 (9:16) @ 1x speed => 0:13 / 10:50 (4:38) @ 2x speed

@ajayyy
Copy link
Owner
ajayyy commented Sep 5, 2023

I don't think this makes sense as a default. It could be an option though

@mchangrh
Copy link
Contributor

I don't think this makes sense at all unless you correct youtube's current and end times to also align with the time without segments - in which case it would be better suited for a plugin/userscript to parse instead for uniformity across all durations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vicente-higino @ajayyy @mchangrh
0