8000 Update drools folding to include 'global' and 'import' by h11sam · Pull Request #5775 · ajaxorg/ace · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update drools folding to include 'global' and 'import' #5775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

Update drools folding to include 'global' and 'import' #5775

merged 1 commit into from
Mar 25, 2025

Conversation

h11sam
Copy link
Contributor
@h11sam h11sam commented Mar 21, 2025

Issue #, if available: N/A

Updated the drools mode's folding so that both global and import can be also be folded as well. I have also added in a test as there was not one included beforehand.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

@codecov Codecov
Copy link
codecov bot commented Mar 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.22%. Comparing base (1c16b49) to head (ae512c9).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/mode/folding/drools_test.js 97.22% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5775      +/-   ##
==========================================
+ Coverage   87.17%   87.22%   +0.04%     
==========================================
  Files         603      604       +1     
  Lines       44235    44304      +69     
  Branches     7254     7265      +11     
==========================================
+ Hits        38561    38643      +82     
+ Misses       5674     5661      -13
Flag Coverage Δ
unittests 87.22% <98.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@akoreman akoreman merged commit 78ad9c7 into ajaxorg:master Mar 25, 2025
3 checks passed
@akoreman
Copy link
Contributor

Thanks for your contribution 🚀 the change will be included in the next Ace release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoreman akoreman akoreman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h11sam @akoreman
0