8000 fixes #5130: Wrong text color in solarized_dark.css.js (Updated) by gurvirbaraich · Pull Request #5137 · ajaxorg/ace · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fixes #5130: Wrong text color in solarized_dark.css.js (Updated) #5137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fixes #5130: Wrong text color in solarized_dark.css.js (Updated) #5137

wants to merge 1 commit into from

Conversation

gurvirbaraich
Copy link

Screenshot 2023-04-22 at 2 56 40 PM

@gurvirbaraich gurvirbaraich mentioned this pull request Apr 22, 2023
Closed
@codecov
Copy link
codecov bot commented May 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.15 🎉

Comparison is base (23d4df6) 86.71% compared to head (71a6ebb) 86.86%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5137      +/-   ##
==========================================
+ Coverage   86.71%   86.86%   +0.15%     
==========================================
  Files         556      558       +2     
  Lines       43492    43996     +504     
  Branches     6762     6926     +164     
==========================================
+ Hits        37714    38218     +504     
  Misses       5778     5778
Flag Coverage Δ
unittests 86.86% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@InspiredGuy
Copy link
Contributor

This PR is exactly the same as the previously closed one - #5133, but seems like the issue #5130 mentions one of the changes might be incorrect. Could you please double-check?
P.S. You don't have to re-create a PR in case you need to make some changes, just push another commit to the branch from which you made a PR (in this case fixed-solarized-dark-theme-text-color-issue-updated)

@gurvirbaraich
Copy link
Author

@InspiredGuy, This PR is not same to the closed PR #5133, on the issue #5130 (comment) doom-goober reclarified the issue and this PR fixes the same.

@InspiredGuy
Copy link
Contributor

@gurvirbaraich I see exactly the same diff when I open changed files of both PRs (see screenshots below). maybe I'm missing something, could you please point out what is different between those two?
this PR:
image
closed PR:
image

@gurvirbaraich
Copy link
Author

Let me check. I will update the PR accordingly. Thanks @InspiredGuy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gurvirbaraich @InspiredGuy
0