[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS Worker support for CSS Nesting #5559

Closed
2 tasks
TimChinye opened this issue May 22, 2024 · 3 comments
Closed
2 tasks

CSS Worker support for CSS Nesting #5559

TimChinye opened this issue May 22, 2024 · 3 comments
Labels
feature-request needs-triage

Comments

@TimChinye
Copy link

Describe the feature

Any code that uses the new Nesting feature of CSS gets a bunch of invalid errors.

Valid CSS Code with a ton of errors due to this outdated worker

Use Case

It completely breaks the syntax validation for all code using CSS Nesting.

Proposed Solution

I can just disable the worker, temporarily, until a fix comes using <Ace>.getSession().setUseWorker(false);.

Other Information

Unlike the CSS Mode, this isn't a major issue as it's more of a visual bug.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

ACE version used

1.33.3
@nightwing
Copy link
Member

Using https://github.com/mkslanc/ace-linters fixes this issue, see the playground example here

Perhaps we should also consider replacing old workers in ace-builds with the ones from ace-linters?

@TimChinye
Copy link
Author

Highly agree, ace-linters works perfectly.

@akoreman
Copy link
Contributor

Thanks for opening the issue. Given that ace-linters offers a way better experience here, I don't think we'll be addressing issues in the stale CSS worker code.

@TimChinye TimChinye mentioned this issue May 29, 2024
Closed
TimChinye added a commit to TimChinye/ace that referenced this issue Nov 15, 2024
@TimChinye
Update css_highlight_rules.js
d42da3d 
<!--
Most of the files here are generated with a build script, so You probably
should submit your pull request to https://github.com/ajaxorg/ace instead
-->

*Issue #, if available:* [ajaxorg#5559](ajaxorg#5559)

*Description of changes:* Updated the mode-css.js file to latest CSS specifications, using MDN provided information and [Ace Linters](https://github.com/mkslanc/ace-linters).

*Additional Info:*
- Ace Linters supports Non-standard and Deprecated code, but not Experimental - this CSS Mode complies with that.
- `khz` and `hz` units are no longer supported, as they're technically experimental (as in - they have not use "yet"), `gd` unit has been removed as it's seemingly a myth. Was mentioned in a single version of a CSS specification with zero information to go along with it, and removed within a year.
- Still does not take into consideration the new CSS Nesting.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
@TimChinye TimChinye mentioned this issue Nov 15, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request needs-triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nightwing @akoreman @TimChinye