8000 feat: Azure Blob source connector by harshini-rangaswamy · Pull Request #876 · aiven/aiven-docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Azure Blob source connector #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 16, 2025
Merged

feat: Azure Blob source connector #876

merged 10 commits into from
Jun 16, 2025

Conversation

harshini-rangaswamy
Copy link
Contributor
@harshini-rangaswamy harshini-rangaswamy commented May 27, 2025 •
edited
Loading

Describe your changes

Azure Blob source connector documentation, including example config and DR usage.

KCON-156

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link
cloudflare-workers-and-pages bot commented May 27, 2025 •
edited
Loading

Deploying aiven-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d70b70
Status: ✅  Deploy successful!
Preview URL: https://85f438a5.aiven-docs.pages.dev
Branch Preview URL: https://kcon-156-release-documentati.aiven-docs.pages.dev

View logs

jclarysse
jclarysse previously requested changes May 28, 2025
View reviewed changes
Copy link
Contributor
@jclarysse jclarysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshini-rangaswamy I spotted a few things

Claudenw
Claudenw requested changes May 28, 2025
View reviewed changes
Claudenw
Claudenw reviewed May 29, 2025
View reviewed changes
@harshini-rangaswamy harshini-rangaswamy self-assigned this May 30, 2025
jclarysse

This comment was marked as duplicate.

Sign in to view

@harshini-rangaswamy
Copy link
Contributor Author

I doubt both properties are valid or needed at the same time. Moreover it might be useful to indicate how to authenticate to the Schema registry. It should work the exact same way as documented in the note here: https://aiven.io/docs/products/kafka/kafka-connect/howto/http-sink#define-a-kafka-connect-configuration-file

Thanks, @jclarysse. To confirm, for this source connector, is schema.registry.url alone sufficient when using avro or parquet, assuming we are not setting a custom value converter? If so, I can remove value.converter.schema.registry.url.

Claudenw
Claudenw approved these changes Jun 3, 2025
View reviewed changes
Copy link
@Claudenw Claudenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for all the effort particularly the wordsmithing

Claudenw
Claudenw requested changes Jun 3, 2025
View reviewed changes
Copy link
@Claudenw Claudenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for all the effort particularly the wordsmithing
Sorry for the incorrect documentation that I provided earlier.

@harshini-rangaswamy harshini-rangaswamy marked this pull request as ready for review June 5, 2025 13:59
@harshini-rangaswamy harshini-rangaswamy requested a review from a team as a code owner June 5, 2025 13:59
Claudenw
Claudenw approved these changes Jun 6, 2025
View reviewed changes
Copy link
@Claudenw Claudenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noted a few places where I think you may have documentation problems in the future. If you are not inclined to change them then feel free to merge.

@harshini-rangaswamy
update: feedback
aa1b285
@harshini-rangaswamy
update: intro
1c4bc2b
@harshini-rangaswamy
update: content
edc34f2 
Please enter the commit message for your changes. Lines starting
@harshini-rangaswamy harshini-rangaswamy force-pushed the KCON-156-release-documentation-for-azure-blob-source-dr-focus branch from 8a74d97 to edc34f2 Compare June 6, 2025 14:50
staceysalamon-aiven
staceysalamon-aiven approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor
@staceysalamon-aiven staceysalamon-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small style note and also a suggestion for adding TF to this

@harshini-rangaswamy harshini-rangaswamy added the review/awaitingRelease All reviews are completed. label Jun 11, 2025
@harshini-rangaswamy harshini-rangaswamy merged commit 4cb79e1 into main Jun 16, 2025
5 checks passed
@harshini-rangaswamy harshini-rangaswamy deleted the KCON-156-release-documentation-for-azure-blob-source-dr-focus branch June 16, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jclarysse jclarysse jclarysse left review comments

@Claudenw Claudenw Claudenw approved these changes

@staceysalamon-aiven staceysalamon-aiven staceysalamon-aiven approved these changes

@davide-armand davide-armand Awaiting requested review from davide-armand

Assignees

@harshini-rangaswamy harshini-rangaswamy

Labels
review/awaitingRelease All reviews are completed. service/kafka_connect service/kafka
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshini-rangaswamy @Claudenw @jclarysse @staceysalamon-aiven
0