Selectors do not raise a warning, if input values are NaN #26
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cisert
reviewed
May 5, 2025
Comment on lines
+31
to
+54
| @pytest.mark.filterwarnings("error") | ||
| @pytest.mark.parametrize("smaller_is_better", [False, True]) | ||
| @pytest.mark.parametrize( | ||
| "selector", | ||
| [ | ||
| peppr.MeanSelector(), | ||
| peppr.OracleSelector(), | ||
| peppr.TopSelector(5), | ||
| peppr.TopSelector(1), | ||
| peppr.RandomSelector(5, seed=0), | ||
| ], | ||
| ids=lambda selector: selector.name, | ||
| ) | ||
| def test_nan_values(selector, smaller_is_better): | ||
| """ | ||
| Check that :meth:`Selector.select()` returns NaN if all values are NaN, without | ||
| raising a warnings. | ||
| If any value is not NaN, the selector should return an actual value. | ||
| """ | ||
| values = np.full(10, np.nan) | ||
| assert np.isnan(selector.select(values, smaller_is_better)) | ||
| # Expect a non-NaN value if the input contains any non-NaN value | ||
| values = np.concatenate([np.arange(9), [np.nan]]) | ||
| assert not np.isnan(selector.select(values, smaller_is_better)) |
There was a problem hiding this comment.
@pytest.mark.filterwarnings("error")
Would this fail if we raised a warning? 🤔
cisert
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.