8000 Use substructure matching without conformation as fallback by padix-key · Pull Request #19 · aivant/peppr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use substructure matching without conformation as fallback #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

padix-key
Copy link
Collaborator

Currently atom matching in small molecules may fail, not due to different atoms or bond graphs, but due to different conformations, if they result in different chirality. This PR adds a fallback to substructure matching, that find corresponding atoms without taking chirality into account, if taking chirality into account fails.

@padix-key padix-key requested a review from emalgorithm April 28, 2025 10:18
Copy link
Contributor
@emalgorithm emalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot! 🚢

@padix-key padix-key merged commit bd2a905 into main Apr 29, 2025
6 checks passed
@padix-key padix-key deleted the matching branch April 29, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0