feat(redis): Use Redis PubSub #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o we can support node per sync job
There was a problem hiding this comment.
cubic found 1 issue across 5 files. Review it in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
| redis.Redis: Configured Redis client instance. | ||
| """ | ||
| return redis.Redis( | ||
| host=settings.REDIS_HOST, |
There was a problem hiding this comment.
Connection configuration omits authentication and database selection, ignoring settings.REDIS_PASSWORD and settings.REDIS_DB; deployments requiring a password or non-default DB will fail to connect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the in-memory pubsub with Redis pubsub.
Then we can allow multiple nodes to share the pubsub.
Summary by cubic
Replaced the in-memory pubsub system with Redis PubSub to allow sync job updates to be shared across multiple nodes.