Prepare for release 1.3.0 #39
Conversation
| @@ -1,5 +1,5 @@ | |||
| VERSION_CODE=1 | |||
There was a problem hiding this comment.
I think you'll want to bump the version code too, no?
There was a problem hiding this comment.
I've followed Felipe's example in other open source libraries and don't see this done. I'm not actually sure what this version code does but it doesn't seem used. I"ll talk to felipe
There was a problem hiding this comment.
Hm, okay. I've always bumped it when bumping versions but mostly out of ceremony and not necessarily knowing what it does (although I always thought it might have mattered for some maven dependency related reasons).
| @@ -1,3 +1,9 @@ | |||
| # 1.3.0 (09/15/2016) | |||
There was a problem hiding this comment.
You could potentially mention the NPE fix? Not sure how relevant it is.
There was a problem hiding this comment.
I would be incredibly surprised if anyone ran into it, which is why I didn't put it. more likely to confuse people since it's a bit complicated. I could add it though.
There was a problem hiding this comment.
Got it, sounds like it doesn't need to be added!
@gpeal @seanabraham