8000 ExcludeRegex by kyleu · Pull Request #158 · air-verse/air · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ExcludeRegex #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2021
Merged

ExcludeRegex #158

merged 2 commits into from
Apr 23, 2021

Conversation

kyleu
Copy link
Contributor
@kyleu kyleu commented Apr 17, 2021

Adding ExcludeRegex to build config, excluding files based on compiled regular expressions. Test included.

@kyleu
Copy link
Contributor Author
kyleu commented Apr 17, 2021

Thanks for building air, I've used it in a dozen projects. This PR covers the case where you want to exclude files based on a regex pattern. In my case, I was using quicktemplate to generate .html.go files from .html, and needed to exclude only the generated files in that directory.

@codecov
Copy link
codecov bot commented Apr 17, 2021

Codecov Report

Merging #158 (515d79d) into master (45c6424) will increase coverage by 0.29%.
The diff coverage is 37.50%.

❗ Current head 515d79d differs from pull request most recent head 2f0f5f3. Consider uploading reports for the commit 2f0f5f3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   32.46%   32.75%   +0.29%     
==========================================
  Files           5        5              
  Lines         499      522      +23     
==========================================
+ Hits          162      171       +9     
- Misses        307      319      +12     
- Partials       30       32       +2
Impacted Files Coverage Δ
runner/engine.go 12.69% <0.00%> (-0.48%) ⬇️
runner/util.go 40.00% <50.00%> (+1.11%) ⬆️
runner/config.go 67.59% <71.42%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c6424...2f0f5f3. Read the comment docs.

@kyleu
Copy link
Contributor Author
kyleu commented Apr 21, 2021

@xiantang Should I open an issue for this, or is the PR sufficient?

@cosmtrek
Copy link
Collaborator

@kyleu Thanks for your contributions, I'll review it~

@cosmtrek cosmtrek merged commit 99f2a65 into air-verse:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmtrek cosmtrek cosmtrek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyleu @cosmtrek
0