feat(AIP-148): introduce purge_time #1169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expire_time for both soft resource purge time and resource expire time (when it will not be useful) could cause user confusion as to whether the resource is soft-deletable or has an expiration. splitting the fields resolves the issue.
alin04
approved these changes
Jul 13, 2023
Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com> Co-authored-by: Angie Lin <angielin@google.com>
toumorokoshi
added a commit
to googleapis/api-linter
that referenced
this pull request
Jul 14, 2023
Updating checking for purge_time to align with aip-dev/google.aip.dev#1169. Continued to ignore expire_time for soft-deleted resources for backwards-compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expire_time for both soft resource purge time and
resource expire time (when it will not be useful) could
cause user confusion as to whether the resource is soft-deletable
or has an expiration.
splitting the fields resolves the issue.
Follow-up checklist: