Log offending websocket client address when no protocols overlap #10564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #10564 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10564 +/- ##
=======================================
Coverage 98.69% 98.70%
=======================================
Files 122 124 +2
Lines 37246 37335 +89
Branches 2065 2063 -2
=======================================
+ Hits 36761 36850 +89
Misses 338 338
Partials 147 147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #10575 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 16, 2025
) <!-- Thank you for your contribution! --> ## What do these changes do? Logs the remote address of a WebSocket client that has no overlapping protocols ## Are there changes in behavior for the user? Which client has the problem should be a bit more discoverable ## Is it a substantial burden for the maintainers to support this? no ## Related issue number closes #10563 (cherry picked from commit a59e74b)
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10576 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 16, 2025
) <!-- Thank you for your contribution! --> ## What do these changes do? Logs the remote address of a WebSocket client that has no overlapping protocols ## Are there changes in behavior for the user? Which client has the problem should be a bit more discoverable ## Is it a substantial burden for the maintainers to support this? no ## Related issue number closes #10563 (cherry picked from commit a59e74b)
bdraco
added a commit
that referenced
this pull request
Mar 16, 2025
…dress when no protocols overlap (#10575) **This is a backport of PR #10564 as merged into master (a59e74b).** <!-- Thank you for your contribution! --> ## What do these changes do? Logs the remote address of a WebSocket client that has no overlapping protocols ## Are there changes in behavior for the user? Which client has the problem should be a bit more discoverable ## Is it a substantial burden for the maintainers to support this? no ## Related issue number closes #10563 Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco
added a commit
that referenced
this pull request
Mar 16, 2025
…dress when no protocols overlap (#10576) **This is a backport of PR #10564 as merged into master (a59e74b).** <!-- Thank you for your contribution! --> ## What do these changes do? Logs the remote address of a WebSocket client that has no overlapping protocols ## Are there changes in behavior for the user? Which client has the problem should be a bit more discoverable ## Is it a substantial burden for the maintainers to support this? no ## Related issue number closes #10563 Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Logs the remote address of a WebSocket client that has no overlapping protocols
Are there changes in behavior for the user?
Which client has the problem should be a bit more discoverable
Is it a substantial burden for the maintainers to support this?
no
Related issue number
closes #10563