[PR #9031/9f0ae074 backport][3.11] Avoid tracing overhead in http_writer when there are no traces #9046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 9f0ae07)
bdraco
approved these changes
Sep 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.11 #9046 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 108 108
Lines 34502 34502
Branches 4094 4094
=======================================
Hits 33731 33731
Misses 576 576
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…7fd0cfa4d0ca6092d1ee1/pr-9031
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #9031 as merged into master (9f0ae07).
What do these changes do?
If there are not traces set for the request, we would still create partial functions in ClientRequest and call them in http_writer
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no
before
after
