8000 [PR #9031/9f0ae074 backport][3.10] Avoid tracing overhead in http_writer when there are no traces by patchback[bot] · Pull Request #9045 · aio-libs/aiohttp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PR #9031/9f0ae074 backport][3.10] Avoid tracing overhead in http_writer when there are no traces #9045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2024
Merged

[PR #9031/9f0ae074 backport][3.10] Avoid tracing overhead in http_writer when there are no traces #9045

merged 1 commit into from
Sep 6, 2024

Conversation

patchback[bot]
Copy link
Contributor
@patchback patchback bot commented Sep 6, 2024

This is a backport of PR #9031 as merged into master (9f0ae07).

What do these changes do?

If there are not traces set for the request, we would still create partial functions in ClientRequest and call them in http_writer

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

before
write_headers_before

after
write_headers_after

@patchback patchback bot mentioned this pull request Sep 6, 2024
Merged
@bdraco bdraco enabled auto-merge (squash) September 6, 2024 19:29
@codecov Codecov
Copy link
codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (f5bf86a) to head (0eb6783).
Report is 189 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             3.10    #9045   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files         108      108           
  Lines       34406    34406           
  Branches     4084     4084           
=======================================
  Hits        33636    33636           
  Misses        575      575           
  Partials      195      195
Flag Coverage Δ
CI-GHA 97.65% <ø> (ø)
OS-Linux 97.34% <ø> (+<0.01%) ⬆️
OS-Windows 94.90% <ø> (ø)
OS-macOS 97.02% <ø> (-0.01%) ⬇️
Py-3.10.11 97.11% <ø> (ø)
Py-3.10.14 97.04% <ø> (ø)
Py-3.11.9 97.27% <ø> (ø)
Py-3.12.5 97.37% <ø> (ø)
Py-3.8.10 94.53% <ø> (ø)
Py-3.8.18 96.85% <ø> (ø)
Py-3.9.13 97.01% <ø> (ø)
Py-3.9.19 96.95% <ø> (ø)
Py-pypy7.3.16 96.55% <ø> (+<0.01%) ⬆️
VM-macos 97.02% <ø> (-0.01%) ⬇️
VM-ubuntu 97.34% <ø> (+<0.01%) ⬆️
VM-windows 94.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 9c34a8c into 3.10 Sep 6, 2024
31 of 32 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/9f0ae07459844d51a017fd0cfa4d0ca6092d1ee1/pr-9031 branch September 6, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco
0