-
Notifications
You must be signed in to change notification settings - Fork 60
Type Annotations #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sakosha
wants to merge
56
commits into
aio-libs:master
Choose a base branch
from
sakosha:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,290
−600
Open
Type Annotations #188
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
0ef1cc4
added type annotations
sakosha 743be6c
added typing-extensions as a dependency
sakosha cbb43a8
formatting
sakosha b8b4c59
stringify circular references
sakosha 6b45e0b
stringify circular references
sako
8000
sha b86bc9c
stringify circular references
sakosha 03e92d8
mypy ci & pre-commit
sakosha 0078e7e
more general type: ignore for siosocks
sakosha 3d0fa27
added py.typed marker
sakosha 6f064f2
remove deprecated packages from [tool.mypy]
sakosha 94024ef
adjust type ignore for 3.12+
sakosha 9cd8b80
ci w/ explicit-package-bases
sakosha a5e8a11
ci w/ explicit PYTHONPATH tweaking
sakosha 749136c
ci w/ explicit PYTHONPATH tweaking
sakosha cff444b
Merge remote-tracking branch 'origin/master'
sakosha f4ca5ef
ci w/ checking the sources
sakosha b802767
add explicit annotations for Lister.iter class var
sakosha 0864852
added ignore_missing_imports = true
7eeafeb
removed pathlib namespace
2af1dee
removed 3.12+ check from get_stream
6df0f5f
removed datetime module namespace
94f5d3f
specify src dir for mypy
8f5ceee
do not specify files for mypy in CI
ed631c5
remove uv.lock
d443be1
use property to unify `if stream is None` check
f55095b
remove explicit file paths from pre-commit mypy
7bef304
make parse_line methods accept bytes only
768e1d4
make parse_line methods accept bytes only
c597018
close shall use _stream value directly
a73de68
use <<: *python-linters instead of pass_filenames
48cfc17
move Code into common.py to use `wrap_into_codes`
7516dc3
use 2nd approach from https://github.com/aio-libs/aioftp/pull/188/fil…
ae05da0
use warn_unreachable option for mypy
a8ae0eb
Merge branch 'master' into master
sakosha 12c6336
address https://github.com/aio-libs/aioftp/pull/188/files#r2119625268
sakosha 6635393
remove version check
sakosha 8c138f7
make AbstractPathIO generic over Path type
sakosha f0c9b82
remove easy `server.py` type: ignores
sakosha 3c28d4f
use Node instead of NodeProtocol
sakosha f877596
adjust _blocking_io for `AsyncPathIO.list` method
sakosha ec53fb9
make AbstractPathIO & it's subclasses methods mostly the same
sakosha 8faa523
make Node is_dir/is_file checks explicit for type narrowing
sakosha 8f320f2
convert from pathlib import ...
sakosha e71bc28
partially revert AsyncPathIO __anext__ method
sakosha 52cf765
move type-checking hook to the end
sakosha dcccc55
Merge remote-tracking branch 'upstream/master'
sakosha 8fffd8e
added TODO: remove typing-extensions dependency.
sakosha e711c35
remove redundant type-check ci stage.
sakosha 496c1fd
use local mypy for pre-commit
sakosha f9a616b
Address code review
sakosha 1cda798
add docstring for AsyncListerMixin.__aiter__
sakosha 947f992
use _stream in _open_connection, remove type ignores
sakosha 59cb487
remove Connection quotes
sakosha ff8e598
install `typing-extensions` only for `python-version<3.11`
64cffb4
install `typing-extensions` only for `python-version<3.11`
7638b07
Merge remote-tracking branch 'origin/master'
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.