8000 fix: fix missing num_remote_prefill_groups in vLLM patch by ptarasiewiczNV · Pull Request #981 · ai-dynamo/dynamo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fix missing num_remote_prefill_groups in vLLM patch #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2025
Merged

fix: fix missing num_remote_prefill_groups in vLLM patch #981

merged 2 commits into from
May 7, 2025

Conversation

ptarasiewiczNV
Copy link
Contributor

Overview:

num_remote_prefill_groups parameter that we added to SchedulerPrefillOuputs was missing in one place causing baseline to error.

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@copy-pr-bot copy-pr-bot
Copy link
copy-pr-bot bot commented May 7, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

rmccorm4
rmccorm4 approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor
@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @krishung5

@ptarasiewiczNV ptarasiewiczNV merged commit af9ee90 into main May 7, 2025
6 checks passed
@ptarasiewiczNV ptarasiewiczNV deleted the ptarasiewicz/patch-update branch May 7, 2025 15:13
@wxsms
Copy link
Contributor
wxsms commented May 14, 2025 •
edited
Loading

Hi @ptarasiewiczNV , sorry to border, I saw that #852 is reverted in this PR, is this intended or mistake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@tanmayv25 tanmayv25 Awaiting requested review from tanmayv25 tanmayv25 is a code owner

@ishandhanani ishandhanani Awaiting requested review from ishandhanani ishandhanani is a code owner

@alec-flowers alec-flowers Awaiting requested review from alec-flowers alec-flowers is a code owner

@nnshah1 nnshah1 Awaiting requested review from nnshah1 nnshah1 is a code owner

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptarasiewiczNV @wxsms @rmccorm4
0